-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clearsource history command #268
Merged
amercader
merged 13 commits into
ckan:master
from
GovDataOfficial:clearsource-history-command
Nov 23, 2016
Merged
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e8570b9
Add clearsource history command
raphaelstolt af0e171
Changed filter query for reading harvest sources
seitenbau-govdata 1acab98
Added tests for clearsource history command
seitenbau-govdata cf1cfcc
Fixed using property of object
seitenbau-govdata 8d5ff4b
Fixed harvest_sources_job_history_clear test
seitenbau-govdata 096e746
Fixed HarvestSourceObj argument
seitenbau-govdata d01a866
Fix creating different harvest sources
seitenbau-govdata f68bf32
Using test class wide unique harvest source url
seitenbau-govdata 95d0c1c
Ignoring not existent harvest sources in harvest_sources_job_history_…
seitenbau-govdata d511663
Sort lists for assert
seitenbau-govdata 7f76f60
Fixed variable name
seitenbau-govdata e7c0385
Avoid the "# dont use factory because it looks for the existing sourc…
ff1b861
Update documentation
seitenbau-govdata File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add the limit? e.g. in data.gov.uk we have approximately 20,000 harvested datasets, so this would be no good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is searching for harvest sources, not harvested datasets. It could potentially be an issue on larger instances but I think it's good enough for a first version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, good point @amercader. We have 400 of those. Still, why not remove the limit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The limit is set to the maximum of 1000 because the standard value is only 10 without defining the parameter 'limit'. And 1000 is the hard coded maximum of the limit within package_search. You have to read the harvest source packages in blocks for getting really all harvest sources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough then - thanks for explaining. Perhaps add a note in the documentation about the limit, just in case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidread That's a good idea. I have added a note about the limit right now.