Fix harvest extras for packages #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the harvest information on the package to be easily searched and removes complicated logic for adding/removing extras
|
Passing tests (in case they don't get run here): https://github.com/GSA/ckanext-harvest/actions/runs/1254660702 |
1 task
7 tasks
|
@amercader ping |
fix for py3 also works for py2;
Fix pkg extras
Revert "Fix pkg extras"
Adjust solr index from live tests
Should never be necessary in data.gov, but for upstream.
Bug/clean harvest info
|
Many thanks @jbrown-xentity , this is a much simpler implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that injecting the harvest extra information at search/show time is very complex.
We (US data.gov CKAN team) propose a solution that puts the extra objects into the package itself, and remove the complex necessary code.
This was raised to our attention when we discovered that we had bad data from harvesting another CKAN source, and when the harvest information was no longer displayed when using
package_show, only onpackage_search(which hurt our API users).See example package_search vs package_show
This replaces #438, as our team member Chris has moved onto another project.
@amercader, any possibility we could merge this?