Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSW harvesting fails for all records #3376

Closed
6 of 7 tasks
FuhuXia opened this issue Aug 11, 2021 · 4 comments
Closed
6 of 7 tasks

CSW harvesting fails for all records #3376

FuhuXia opened this issue Aug 11, 2021 · 4 comments
Assignees
Labels
bug Software defect or bug support Issues from agency requests or affecting users

Comments

@FuhuXia
Copy link
Member

FuhuXia commented Aug 11, 2021

On Catalog, CSW harvest stopped working. The harvesting generated an error for each record:

Error getting the CSW record with GUID <###>

How to reproduce

https://catalog.data.gov/harvest/opentopography-csw/job/55b8e5dd-7700-4aa1-9956-2338168c2c2c

Expected behavior

Successful harvest report

Actual behavior

Error for all records

Context

Harvest source side there is no changes. It should be related to recent requirements update we did a few weeks ago.

Sketch

  • Roll back to working version of code (test CSW harvest locally to verify)
  • Explore where CSW harvest code is located (ckanext-spatial, geodatagov, etc)
  • Debug offending code
  • Raise to team for broken components and possible fixes
  • Make fixes (on fork if necessary)
  • Add integration test for CSW harvest (to not backslide)
  • Deploy latest working changes
@FuhuXia FuhuXia added the bug Software defect or bug label Aug 11, 2021
@jbrown-xentity jbrown-xentity added the support Issues from agency requests or affecting users label Aug 12, 2021
@jbrown-xentity
Copy link
Contributor

First step is to roll back to working version of code, we believe this broke on this PR.

@jbrown-xentity
Copy link
Contributor

Using the latest catalog main, csw harvests work for ckan2.9 on python3.
Next I will examine the fcs branch.
image

@jbrown-xentity
Copy link
Contributor

On FCS, the spatial code does not seem to work. I believe it is due to needed later versions of OWSLib, but those are not working well on Python2. I can't find much documentation on the support of OWSLib.
The error comes from here in the ckanext-spatial code. After debugging, I get the following:

fetch_stage error: descriptor 'lower' of 'str' object needs an argument

I believe this is deep in OWSLib, and debugging is painful. My suggestion is to pin spatial in FCS to not get the latest, and only use the latest for Py3 and CKAN2.9.

@nickumia-reisys
Copy link
Contributor

nickumia-reisys commented Sep 21, 2021

I agree with James. I think the main concern was that we weren't sure if harvesting was working for PY3 and it was verified that it does. Tracking two different versions for FCS and cloud.gov is the right approach from my perspective too. I think it's just important to make sure that all of the relevant components were upgraded and they are..

ckanext-spatial,

ckanext-harvest,

ckanext-geodatagov,

ckanext-harvest does have upstream edits and we have two PY3 upgrades that we needed to do, this will get messy if it continues,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software defect or bug support Issues from agency requests or affecting users
Projects
None yet
Development

No branches or pull requests

4 participants