Update shapely usage to avoid deprecation #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only potential problem I see, is that the error message for an invalid geometry is a bit too generic. |
frafra
force-pushed
the
update-shapely-usage-to-avoid-deprecation
branch
from
34d89e0
to
e212662
Compare
frafra
force-pushed
the
update-shapely-usage-to-avoid-deprecation
branch
from
e212662
to
df3af62
Compare
|
Instead of changing the tests, I changed the error handling in the code, and wrote a meaningful error message. That seems good enough for me :) |
|
Thanks, @frafra ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work based on PR #272.