feat: add full version address identifies the hash_type #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keith-CY
changed the title
…_version Add a new format of full address, which identifies the hash_type and vm_version ref nervosnetwork/rfcs#239
Keith-CY
force-pushed
the
add-new-address-format
branch
from
bb03ae9
to
7e2941a
Compare
shaojunda
reviewed
Sep 29, 2021
Keith-CY
changed the title
Keith-CY
force-pushed
the
add-new-address-format
branch
2 times, most recently
from
d2e491d
to
99ff9da
Compare
1. import bech32, bech32m from an external pacakge 2. update format of the new full address
Keith-CY
force-pushed
the
add-new-address-format
branch
from
99ff9da
to
ecf619d
Compare
Codecov Report
@@ Coverage Diff @@
## extends-hash-type #557 +/- ##
=====================================================
- Coverage 96.29% 96.14% -0.16%
=====================================================
Files 50 49 -1
Lines 1566 1529 -37
Branches 301 298 -3
=====================================================
- Hits 1508 1470 -38
- Misses 58 59 +1
|
shaojunda
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new format of full address, which identifies the hash_type
ref nervosnetwork/rfcs#239