RFC21: propose a new full address format #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rev-chaos
changed the title
doitian
changed the title
TheWaWaR
reviewed
Jul 30, 2021
|
I don't have enough scope to review this PR. I recommend @quake and @CipherWang as reviewers. However, if all other reviewers are busy, I'll take some time to understand how these address formats work. |
quake
reviewed
Aug 11, 2021
TheWaWaR
reviewed
Aug 31, 2021
Keith-CY
added a commit
to ckb-js/ckb-sdk-js
that referenced
this pull request
Sep 1, 2021
…_version Add a new format of full address, which identifies the hash_type and vm_version BREAKING CHANGE: Add a new format of full address, which identifies the hash_type and vm_version ref nervosnetwork/rfcs#239
Keith-CY
added a commit
to ckb-js/ckb-sdk-js
that referenced
this pull request
Sep 1, 2021
…_version Add a new format of full address, which identifies the hash_type and vm_version BREAKING CHANGE: Add a new format of full address, which identifies the hash_type and vm_version ref nervosnetwork/rfcs#239
Keith-CY
added a commit
to ckb-js/ckb-sdk-js
that referenced
this pull request
Sep 1, 2021
…_version Add a new format of full address, which identifies the hash_type and vm_version ref nervosnetwork/rfcs#239
rev-chaos
force-pushed
the
add_new_ckb_address_format
branch
from
4eaa4f5
to
1ee0add
Compare
TheWaWaR
reviewed
Sep 6, 2021
quake
previously approved these changes
Sep 10, 2021
Keith-CY
reviewed
Sep 29, 2021
quake
previously approved these changes
Dec 28, 2021
quake
previously approved these changes
Dec 28, 2021
We should keep only one full address format to unify the address format and avoid multiple different address formats that are difficult to understand
rev-chaos
force-pushed
the
add_new_ckb_address_format
branch
from
23dcf67
to
c492539
Compare
quake
approved these changes
Dec 28, 2021
janx
approved these changes
Dec 28, 2021
This was referenced Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.