Fix the problem on destroy happening to fast

[bhugot]

The problem is visible in #110

[bhugot]

Could be fixing also #38

[f1ames]

Thanks for the contribution @bhugot!

I have checked your PR and it looks quite good 👍 Did some minor refactoring. See also one tests related comment.

Looking at your example from #110 I wonder what will happen if component will be shown again (might be the case described in #38). Will the components used inside (so ckeditor one) be initialized as new instances? I'm wondering if _destroyed flag state will be correct in such cases 🤔

Could be fixing also #38

As you also mentioned it, would you be willing to add unit test covering this case also (so probably the same thing I described above too)?

[bhugot]

About the #38 as we don't even call create editor we should not have this problem

[bhugot]

Be aware that there is still a case where it will be failling if the component is in a ng-content as the ngOnDrestroy is not called https://stackblitz.com/edit/angular-ivy-jvybwy?file=src%2Fapp%2Fapp.component.html

[f1ames]

@ezintz Thank you for checking this PR!

Be aware that there is still a case where it will be failling if the component is in a ng-content as the ngOnDrestroy is not called https://stackblitz.com/edit/angular-ivy-jvybwy?file=src%2Fapp%2Fapp.component.html

@bhugot can you elaborate more on this one? I don't see any errors in your code sample (nor CKEditor component)?

[bhugot]

this example only show that when you have a as parent of another component then even if not displayed the ngOnInit is call (look in console log 'Child initialized') but the onDestroy is not call. That can lead on error with CKEditor (it's not an issue with ckeditor-angular) just for reference if someone has this issue sometime after this PR is merged

[f1ames]

this example only show that when you have a as parent of another component then even if not displayed the ngOnInit is call (look in console log 'Child initialized') but the onDestroy is not call. That can lead on error with CKEditor (it's not an issue with ckeditor-angular) just for reference if someone has this issue sometime after this PR is merged

Thanks for the clarification @bhugot 👍 So it seems this is an issue in Angular itself (btw. do you have any number/reference to this issue, was it reported somewhere)?

Do you know any workaround for this issue so we can keep it for future reference?

[bhugot]

An issue on this : angular/angular#18982
One way to handle it, is to use a ng-template so the template is only used when is parent is visible

[f1ames]

Rebased onto latest master.

[f1ames]

LGTM 👍

Thank you for contributing @bhugot!

[bhugot]

You're welcome