Decreased balloon toolbar paddings #1250
Conversation
There was a problem hiding this comment.
Right padding is a bit off in moono-lisa
Seen in http://tests.ckeditor.test:1030/tests/plugins/balloontoolbar/context/manual/context
Similar thing with moono and kama.
http://tests.ckeditor.test:1030/tests/plugins/balloontoolbar/manual/moono
|
@mlewand This is the issue we discussed F2F earlier, buttons and dropdowns has its own right padding/margin. If you take a look on CSS, the right padding was not changed (it is still 0): So previous styling relied on this margin, however now it is too big. We will need a little CSS trickery to remove padding/margin of the last toolbar element and add proper padding here. |
Ohh sorry I actually forgot that. We discussed now once again this matter, and come with a conclusion that it should be possible to adjust that by removing right padding in a wrapper, and leave margin/padding for buttons/richcombo. |
|
@Comandeer could you take over the review from here? |
Comandeer
force-pushed
the
t/933-3224
branch
from
ea6b24c
to
23fead4
Compare
Decreased balloon toolbar paddings
What is the purpose of this pull request?
Task
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What changes did you make?
Decreased balloon toolbar paddings (-2px). Default CSS already has 3px paddings.