Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for: memory leaks #2969

Merged
merged 25 commits into from
Mar 26, 2019
Merged

Fix for: memory leaks #2969

merged 25 commits into from
Mar 26, 2019

Commits on Mar 26, 2019

  1. Prevent adding same styles.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    9e2cfbc View commit details
    Browse the repository at this point in the history

  2. Remove script listeners after load/error.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    4343124 View commit details
    Browse the repository at this point in the history

  3. Remove listener on editor destroy.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    06af05b View commit details
    Browse the repository at this point in the history

  4. Improved comparing stored styles with new ones.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    0b47c15 View commit details
    Browse the repository at this point in the history

  5. Remove setHighlighter once it can't be used.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    7e2af54 View commit details
    Browse the repository at this point in the history

  6. Call autocomplete.destroy on editor.destroy.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    b64b633 View commit details
    Browse the repository at this point in the history

  7. Remove currentInstance if it's destroyed.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    954eaee View commit details
    Browse the repository at this point in the history

  8. Remove stored node when editor is destroyed.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    e87a2c0 View commit details
    Browse the repository at this point in the history

  9. Remove element reference once it's removed.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    3af7dcb View commit details
    Browse the repository at this point in the history

  10. Tests: added test for script load listeners.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    d5bcd3d View commit details
    Browse the repository at this point in the history

  11. Tests: added unit test.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    0b8ba72 View commit details
    Browse the repository at this point in the history

  12. Change event type to pluginsLoaded.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    ca059f7 View commit details
    Browse the repository at this point in the history

  13. Tests: added test case and updated tests after changes.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    62a422a View commit details
    Browse the repository at this point in the history

  14. Tests: added test cast.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    d5102be View commit details
    Browse the repository at this point in the history

  15. Fixed typeerror when destroy is called when view never was attached.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    41a5ee3 View commit details
    Browse the repository at this point in the history

  16. Tests: added unit test.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    d31edb4 View commit details
    Browse the repository at this point in the history

  17. Moved backdoor property to private editor properties.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    091a0e9 View commit details
    Browse the repository at this point in the history

  18. Tests: updated after changes.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    5959863 View commit details
    Browse the repository at this point in the history

  19. Tests: added unit test.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    1426865 View commit details
    Browse the repository at this point in the history

  20. Changelog: added new entry.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    9200c0b View commit details
    Browse the repository at this point in the history

  21. Copied absent CKEDITOR.tools.array.find into local function.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    80865ba View commit details
    Browse the repository at this point in the history

  22. Tests: ignore on built version.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    18a8fbe View commit details
    Browse the repository at this point in the history

  23. Tests: fixed on built version.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    b0e5d10 View commit details
    Browse the repository at this point in the history

  24. Tests: fixed on IE.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    214722c View commit details
    Browse the repository at this point in the history

  25. Changelog: rephrased entry.

    @engineering-this @f1ames
    engineering-this authored and f1ames committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    8e0dd65 View commit details
    Browse the repository at this point in the history