Bugfix - Tableresize not working in maximized mode with divarea #3694
Conversation
|
Hello @arpi68, thanks for contributing! Your pull request is missing tests, see our [Contributing Code](http://docs.ckeditor.com/#!/guide/dev_contributing_code) guide for more details. For such fixes, manual tests should be enough since we are not able to check the resizes visibility reliably with unit tests. Would you be able to provide manual tests fro this PR? |
|
@f1ames shouldn't we merge this PR into |
|
@hub33k if you are asking about target branch then yes, since it is a bugfix it should be targeted to I already retargeted it. |
f1ames
force-pushed
the
arpi68-tableresizepatch-1
branch
from
b1217c9
to
9e13a59
Compare
|
Rebased onto latest |
| </div> | ||
|
|
||
| <script> | ||
| CKEDITOR.replace( 'editor' ); |
There was a problem hiding this comment.
It would be good to have all 3 editor types available in this test, so:
- Classic one (you may use
removePlugins: divareato make sure it's iframe based), divarea- already present,- Inline one - using
CKEDITOR.inline.
This way we may catch any strange behaviors in any editor types (unlikely to happen here, but it's a good practice anyway to have coverage for all editor types).
There was a problem hiding this comment.
Well, there is a slight issue with inline editor since maximze plugin is disabled there (as it doesn't make much sense there).
So maybe let's leave classic and divarea editor as is and for inline editor lets go with some absolute positioned wrapper with high z-index (so we will have also case mentioned in #909) covered. It should be probably a separate manual test then.
There was a problem hiding this comment.
Looks good 👍 Just one thing regarding manual test - see #3694 (comment).
Set z-index of resizer to 10000 or more Fixes these two issues: ckeditor#1959 ckeditor#909
f1ames
force-pushed
the
arpi68-tableresizepatch-1
branch
from
0a0a479
to
5116ec2
Compare
|
Rebased onto latest |
|
@arpi68 Thanks again for contributing to CKEditor 4 🎉👏 |
What is the purpose of this pull request?
Bug fix - Tableresize not working in maximized mode when using divarea
What is the proposed changelog entry for this pull request?
Tableresize not working in maximized mode when using divarea
What changes did you make?
z-index of resizer in maximized mode too low.
Set z-index of resizer to 10000
Which issues your PR resolves?
Closes #1959.
Closes #909.