Fix undo in single cell when using tab key #5407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacekbogdanski
requested changes
Feb 3, 2023
There was a problem hiding this comment.
It looks like a good approach 👍🏻
I slightly updated the manual test - we don't really need 3 editors for that simple change and test steps could be simplified.
One request before we go, it looks like unit tests are passing despite reverting your changes. Could you take a look at it?
KarolDawidziuk
force-pushed
the
t/4829
branch
from
f3d5988
to
29505b6
Compare
jacekbogdanski
force-pushed
the
t/4829
branch
from
29505b6
to
c967971
Compare
jacekbogdanski
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches that change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
Did you follow the CKEditor 4 code style guide?
Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.
What is the proposed changelog entry for this pull request?
What changes did you make?
In the
tabplugin implementation, thecanUndoflag has been set tofalsein theselectNextCellCommand()function.Setting it to "true" solved the problem of being able to undo only one cell instead of the entire table when using the
Tabkey to move between cells.Which issues does your PR resolve?
Closes #4829.