Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo reverse entire table content instead of single cell #4829

Closed
sculpt0r opened this issue Aug 12, 2021 · 1 comment · Fixed by #5407
Closed

Undo reverse entire table content instead of single cell #4829

sculpt0r opened this issue Aug 12, 2021 · 1 comment · Fixed by #5407
Assignees
Labels
plugin:table The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.

Comments

@sculpt0r
Copy link
Contributor

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Create a standard table
  2. Write some text in a single cell
  3. Jump to the next cell with the 'tab' key
  4. Write text to each cell
  5. Use undo button

Expected result

What is the expected result of the above steps?
Text from the last cell is removed. All other cells contain text.
There is undo step for each cell.

Actual result

What is the actual result of the above steps?
There is a single undo step that reverses the entire input from the table.

Other details

  • Browser: -
  • OS: -
  • CKEditor version: PROD (pre-released) 4.16.2
  • Installed CKEditor plugins: table
@sculpt0r sculpt0r added type:bug A bug. status:confirmed An issue confirmed by the development team. plugin:table The plugin which probably causes the issue. labels Aug 12, 2021
@jacekbogdanski
Copy link
Member

Could be probably fixed similarly like

// Click should create a snapshot if needed, but shouldn't cause change event.
// Don't pass onNavigationKey directly as a listener because it accepts one argument which
// will conflict with evt passed to listener.
// https://dev.ckeditor.com/ticket/12324 comment:4
editable.attachListener( editable.isInline() ? editable : editor.document.getDocumentElement(), 'click', function() {
that.onNavigationKey();
}, null, null, 999 );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin:table The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants