Fix tableresize to only attach to tables within containing editor #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tableresize plugin attached mouse move handler to document body element. As a result any tables on the same page as a ckeditor that was created using either divarea or inline editing will become resizeable. When an iframe is used, it is acceptable to attach to body. When inline or divarea is used, one must filter table resize events to only those contained within an actual ckeditor.
|
Thanks! I confirm the issue and redirect the further discussion to #11603. |
|
Hi! I checked this solution but when I applied your commit, table resize stops working in classic editor (based on iFrame). I created slightly different solution, so this bug should be fixed in 4.3.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tableresize plugin attached mouse move handler to document body
element. As a result any tables on the same page as a ckeditor that
was created using either divarea or inline editing will become
resizeable.
When an iframe is used, it is acceptable to attach to body. When
inline or divarea is used, one must filter table resize events to
only those contained within an actual ckeditor.