Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme lacks the build editor step #171

Closed
viktorvavilov opened this issue Mar 3, 2020 · 2 comments · Fixed by #174
Closed

Readme lacks the build editor step #171

viktorvavilov opened this issue Mar 3, 2020 · 2 comments · Fixed by #174
Assignees
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone

Comments

@viktorvavilov
Copy link

Repository is incomplete and has missed files.

ERROR in src/app/context-demo/context-demo.ts:3:27 - error TS2307: Cannot find module '../../../ckeditor/build/cksource'.

3 import * as CKSource from '../../../ckeditor/build/cksource';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/app/demo-form/demo-form.component.ts:8:27 - error TS2307: Cannot find module '../../../ckeditor/build/cksource'.

8 import * as CKSource from '../../../ckeditor/build/cksource';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/app/demo-reactive-form/demo-reactive-form.component.ts:7:27 - error TS2307: Cannot find module '../../../ckeditor/build/cksource'.

7 import * as CKSource from '../../../ckeditor/build/cksource';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/app/simple-usage/simple-usage.component.ts:2:27 - error TS2307: Cannot find module '../../../ckeditor/build/cksource'.

2 import * as CKSource from '../../../ckeditor/build/cksource';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/app/watchdog-demo/watchdog-demo.ts:3:27 - error TS2307: Cannot find module '../../../ckeditor/build/cksource'.

3 import * as CKSource from '../../../ckeditor/build/cksource';

@Mgsy
Copy link
Member

Mgsy commented Mar 3, 2020

Hi, thanks for the report. Actually, as I can see, the project misses some key steps to follow in readme. We'll fix it.

So, please follow the below instructions:

  1. In the main sample directory run npm install.
  2. Go to CKEditor 5 directory and install dependencies - cd vendor/ckeditor5 && npm install && cd ../..
  3. Build the app - npm run build.
  4. Start the app - npm run serve.

Let me know if above helps.

@Mgsy Mgsy added the pending:feedback This issue is blocked by necessary feedback. label Mar 3, 2020
@ma2ciek ma2ciek self-assigned this Mar 3, 2020
@ma2ciek ma2ciek added type:task This issue reports a chore (non-production change) and other types of "todos". and removed pending:feedback This issue is blocked by necessary feedback. labels Mar 3, 2020
@ma2ciek
Copy link
Contributor

ma2ciek commented Mar 3, 2020

I'm sorry @viktorvavilov, I forgot to update the readme.

@ma2ciek ma2ciek added this to the iteration 30 milestone Mar 3, 2020
@ma2ciek ma2ciek changed the title npm run start not working Readme lacks the build editor step Mar 3, 2020
@ma2ciek ma2ciek mentioned this issue Mar 4, 2020
ma2ciek added a commit that referenced this issue Mar 4, 2020
Docs: Added missing build step in docs. Closes #171.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants