Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

t/ckeditor5-editor-decoupled/10: Updated the build to the latest DecoupledEditor API #5

Merged
merged 5 commits into from
Mar 29, 2018

Conversation

oleq
Copy link
Member

@oleq oleq commented Mar 27, 2018

Suggested merge commit message (convention)

Other: Updated the build to the latest DecoupledEditor class API (see ckeditor/ckeditor5#2245).


Requires ckeditor/ckeditor5-editor-decoupled#11.

@oleq
Copy link
Member Author

oleq commented Mar 29, 2018

The build process is broken


ERROR in ../ckeditor5-easy-image/src/cloudservicesuploadadapter.js
Module not found: Error: Can't resolve '@ckeditor/ckeditor-cloud-services-core/src/uploadgateway/uploadgateway' in '/Users/oleq/CK/5/ckeditor5/packages/ckeditor5-easy-image/src'
 @ ../ckeditor5-easy-image/src/cloudservicesuploadadapter.js 12:0-99
 @ ../ckeditor5-easy-image/src/easyimage.js
 @ ./src/ckeditor.js

ERROR in ../ckeditor5-easy-image/src/cloudservicesuploadadapter.js
Module not found: Error: Can't resolve '@ckeditor/ckeditor5-cloud-services/src/cloudservices' in '/Users/oleq/CK/5/ckeditor5/packages/ckeditor5-easy-image/src'
 @ ../ckeditor5-easy-image/src/cloudservicesuploadadapter.js 13:0-81
 @ ../ckeditor5-easy-image/src/easyimage.js
 @ ./src/ckeditor.js

Edit: It's probably due to outdated packages in my local env. Checking...

@Reinmar
Copy link
Member

Reinmar commented Mar 29, 2018

Do you have this locally? We renamed @ckeditor/ckeditor-cloud-services-core recently. Did you update to that?

@Reinmar
Copy link
Member

Reinmar commented Mar 29, 2018

Works like a charm for me.

@Reinmar
Copy link
Member

Reinmar commented Mar 29, 2018

OK, there's another problem. Only using the latest master of ckeditor5-dev you'll be able to compile a build now. That's due to:

commit 6c69057249c8db63f0342fce7643b8707d3dc634
Merge: 9924e65 d80d161
Author: Piotrek Koszuliński <pkoszulinski@gmail.com>
Date:   Tue Mar 27 17:15:42 2018 +0200

    Merge pull request #385 from ckeditor/t/ckeditor5/914

    Fix: Enabled builds to work with RequireJS. Closes ckeditor/ckeditor5#914.

    BREAKING CHANGES: Due to a new format of translation snippets the new version of `CKEditor5WebpackPlugin` will only be compatible with CKEditor 5 v1.0.0-beta.2 or later.

I'm not able to release this for now because it will break fresh installations (in case someone will do npm i --save-dev @ckeditor/ckeditor5-dev-webpack-plugin).

@Reinmar
Copy link
Member

Reinmar commented Mar 29, 2018

I'm adding BREAKING CHANGE section in the commit message because the API of the build is based on the API of the editor and it's good to broadcast such crucial information.

@Reinmar Reinmar merged commit 7b4aef1 into master Mar 29, 2018
@Reinmar Reinmar deleted the t/ckeditor5-editor-decoupled/10 branch March 29, 2018 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants