This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
t/10: Allowed the editable element in DecoupledEditor.constructor(). Removed config.toolbarContainer and config.editableContainer. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uctor(). Removed config.toolbarContainer and config.editableContainer.
Reinmar
reviewed
Mar 28, 2018
| @@ -58,9 +61,13 @@ The code you have just created will run the editor but still, the user interface | |||
| The following structure has two containers that correspond to the configuration you have just used. The editor will inject the toolbar and editable into respective containers as it starts. | |||
|
|
|||
| ```html | |||
| <div class="document-editor"> | |||
| <div class="document-editor ck-rounded-corners"> | |||
There was a problem hiding this comment.
Why is it required to add this class manually? This is unclear for me why, as an integration developer, I'd need to add some CKE's class to my elements to make buttons in the toolbar rounded.
|
It's very odd, but the builds are constantly failing: see e.g. https://travis-ci.org/ckeditor/ckeditor5-editor-decoupled/builds/359460250 Chrome runs ok, but then the 3 other browsers (local FF and BrowserStack's Edge and Safari) crash:
They crash somewhere around 13th test. Crash or timeout, because the timing is weird too. When running these tests locally once or twice I got them to crash too. But this is oooood. |
|
Unfortunately, R- due to failing tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Allowed the editable element to be passed into
DecoupledEditor.constructor(). Removedconfig.toolbarContainerandconfig.editableContainer. Closes ckeditor/ckeditor5#2245. Closes ckeditor/ckeditor5#912.BREAKING CHANGE: The config options
config.toolbarContainerandconfig.editableContainerhave been removed. Please refer to theDecoupledEditorclass API documentation to learn about possible methods of bootstrapping the UI.Additional information
It's a constellation: