-
Notifications
You must be signed in to change notification settings - Fork 19
t/10: Allowed the editable element in DecoupledEditor.constructor(). Removed config.toolbarContainer and config.editableContainer. #11
Conversation
…uctor(). Removed config.toolbarContainer and config.editableContainer.
@@ -58,9 +61,13 @@ The code you have just created will run the editor but still, the user interface | |||
The following structure has two containers that correspond to the configuration you have just used. The editor will inject the toolbar and editable into respective containers as it starts. | |||
|
|||
```html | |||
<div class="document-editor"> | |||
<div class="document-editor ck-rounded-corners"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it required to add this class manually? This is unclear for me why, as an integration developer, I'd need to add some CKE's class to my elements to make buttons in the toolbar rounded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 63683b6.
It's very odd, but the builds are constantly failing: see e.g. https://travis-ci.org/ckeditor/ckeditor5-editor-decoupled/builds/359460250 Chrome runs ok, but then the 3 other browsers (local FF and BrowserStack's Edge and Safari) crash: They crash somewhere around 13th test. Crash or timeout, because the timing is weird too. When running these tests locally once or twice I got them to crash too. But this is oooood. |
Unfortunately, R- due to failing tests. |
Suggested merge commit message (convention)
Other: Allowed the editable element to be passed into
DecoupledEditor.constructor()
. Removedconfig.toolbarContainer
andconfig.editableContainer
. Closes ckeditor/ckeditor5#2245. Closes ckeditor/ckeditor5#912.BREAKING CHANGE: The config options
config.toolbarContainer
andconfig.editableContainer
have been removed. Please refer to theDecoupledEditor
class API documentation to learn about possible methods of bootstrapping the UI.Additional information
It's a constellation: