T/473: Remove gulp dependency #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinmar
reviewed
Oct 13, 2017
scripts/docs/build-docs.js
Outdated
|
|
||
| 'use strict'; | ||
|
|
||
| const assertIsInstalled = require( './../util/assertisinstalled' ); |
There was a problem hiding this comment.
Let's call this directory utils/ to be consistent.
|
I've just checked all the tasks. All works fine. |
|
@szymonkups I don't want to merge this PR and leave, but it LGTM too. I think you can merge it but please check the docs for some leftovers, cause I haven't checked that bit. |
|
I've checked both PR's and everything seems fine. But I will not close them: after merging PR in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Remove gulp dependency in favor of npm scripts. Closes #473.
BREAKING CHANGE: Gulp task are removed. New npm scripts were introduced for dev related tasks.
Additional information
./scripts/releaseand./scripts/docs) and are invoked by appropriate npmrun-script.