Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not crash when creating inherited events when an interface extends a type #923

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

psmyrek
Copy link
Contributor

@psmyrek psmyrek commented Sep 26, 2023

Suggested merge commit message (convention)

Fix (typedoc-plugins): Fixed typedoc-plugin-event-inheritance-fixer plugin to not crash when creating inherited events if an interface extends a type. Closes ckeditor/ckeditor5#15063.

@psmyrek psmyrek requested a review from pomek September 26, 2023 09:00
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

yarn docs does not crash anymore.

Unfortunately, CI results sound weird.

@coveralls
Copy link

Coverage Status

coverage: 90.117% (+0.001%) from 90.116% when pulling a0b2b91 on ck/15063 into d0e32b3 on master.

@pomek pomek merged commit c7608b7 into master Sep 26, 2023
3 checks passed
@pomek pomek deleted the ck/15063 branch September 26, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants