Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the name of the main file to classiceditor to reflect class name #2218

Closed
Reinmar opened this issue Dec 4, 2016 · 1 comment · Fixed by ckeditor/ckeditor5-editor-classic#59
Closed

Change the name of the main file to classiceditor to reflect class name #2218

Reinmar opened this issue Dec 4, 2016 · 1 comment · Fixed by ckeditor/ckeditor5-editor-classic#59
Assignees
@oleq
Labels
package:editor-classic type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 11

Comments

@Reinmar
Copy link
Member

Reinmar commented Dec 4, 2016

The file is now named classic.js in order to better work with ckeditor5-editor-classic (it matches the last word and tries to follow the short feature naming pattern where link == link/link). However, that's as confusing as the inconsistent order in ckeditor5-editor-classic/classiceditor.js, so, since the shortened feature naming is gone, it's better to just stick to the general naming pattern where file name reflects the class name.
@Reinmar
Copy link
Member Author

Reinmar commented Jun 13, 2017

This change should also be done in the two other editors and perhaps in more places (such as the builds and many tests).

@oleq oleq self-assigned this Jun 14, 2017
oleq referenced this issue in ckeditor/ckeditor5-basic-styles Jun 14, 2017
@oleq
Other: Updated the path to the ClassicEditor class (see https://githu…
5a3e20a 
…b.com/ckeditor/ckeditor5-editor-classic/issues/41).
oleq referenced this issue in ckeditor/ckeditor5-block-quote Jun 14, 2017
@oleq
Other: Updated the path to the ClassicEditor class (see https://githu…
154652e 
…b.com/ckeditor/ckeditor5-editor-classic/issues/41).
oleq referenced this issue in ckeditor/ckeditor5-adapter-ckfinder Jun 14, 2017
@oleq
Other: Updated the path to the ClassicEditor class (see https://githu…
22bbb00 
…b.com/ckeditor/ckeditor5-editor-classic/issues/41).
oleq referenced this issue in ckeditor/ckeditor5-autoformat Jun 14, 2017
@oleq
Other: Updated the path to the ClassicEditor class (see https://githu…
513ca9f 
…b.com/ckeditor/ckeditor5-editor-classic/issues/41).
oleq referenced this issue in ckeditor/ckeditor5-build-classic Jun 14, 2017
@oleq
Other: Updated the path to the ClassicEditor class (see https://githu…
66388bc 
…b.com/ckeditor/ckeditor5-editor-classic/issues/41).
oleq referenced this issue in ckeditor/ckeditor5-clipboard Jun 14, 2017
@oleq
Other: Updated the path to the ClassicEditor class (see https://githu…
15456a4 
…b.com/ckeditor/ckeditor5-editor-classic/issues/41).
oleq referenced this issue in ckeditor/ckeditor5-enter Jun 14, 2017
@oleq
Other: Updated the path to the ClassicEditor class (see https://githu…
21e8805 
…b.com/ckeditor/ckeditor5-editor-classic/issues/41).
oleq referenced this issue in ckeditor/ckeditor5-heading Jun 14, 2017
@oleq
Other: Updated the path to the ClassicEditor class (see https://githu…
1b5494b 
…b.com/ckeditor/ckeditor5-editor-classic/issues/41).
oleq referenced this issue in ckeditor/ckeditor5-engine Jun 14, 2017
@oleq
Other: Updated the path to the ClassicEditor class (see https://githu…
8b4a9db 
…b.com/ckeditor/ckeditor5-editor-classic/issues/41).
oleq referenced this issue in ckeditor/ckeditor5-image Jun 14, 2017
@oleq
Other: Updated the path to the ClassicEditor class (see https://githu…
feac03d 
…b.com/ckeditor/ckeditor5-editor-classic/issues/41).
oleq referenced this issue in ckeditor/ckeditor5-link Jun 14, 2017
@oleq
Other: Updated the path to the ClassicEditor class (see https://githu…
175aa1f 
…b.com/ckeditor/ckeditor5-editor-classic/issues/41).
oleq referenced this issue in ckeditor/ckeditor5-list Jun 14, 2017
@oleq
Other: Updated the path to the ClassicEditor class (see https://githu…
61cb52a 
…b.com/ckeditor/ckeditor5-editor-classic/issues/41).
oleq referenced this issue in ckeditor/ckeditor5-paragraph Jun 14, 2017
@oleq
Other: Updated the path to the ClassicEditor class (see https://githu…
dac69c6 
…b.com/ckeditor/ckeditor5-editor-classic/issues/41).
oleq referenced this issue in ckeditor/ckeditor5-essentials Jun 14, 2017
@oleq
Other: Updated the path to the ClassicEditor class (see https://githu…
2ac4013 
…b.com/ckeditor/ckeditor5-editor-classic/issues/41).
oleq referenced this issue in ckeditor/ckeditor5-undo Jun 14, 2017
@oleq
Other: Updated the path to the ClassicEditor class (see https://githu…
16ed161 
…b.com/ckeditor/ckeditor5-editor-classic/issues/41).
oleq referenced this issue in ckeditor/ckeditor5-ui Jun 14, 2017
@oleq
Other: Updated the path to the ClassicEditor class (see https://githu…
3961dd7 
…b.com/ckeditor/ckeditor5-editor-classic/issues/41).
oleq referenced this issue in ckeditor/ckeditor5-typing Jun 14, 2017
@oleq
Other: Updated the path to the ClassicEditor class (see https://githu…
68d28c7 
…b.com/ckeditor/ckeditor5-editor-classic/issues/41).
oleq referenced this issue in ckeditor/ckeditor5-upload Jun 14, 2017
@oleq
Other: Updated the path to the ClassicEditor class (see https://githu…
e62ff04 
…b.com/ckeditor/ckeditor5-editor-classic/issues/41).
szymonkups referenced this issue in ckeditor/ckeditor5-block-quote Jun 19, 2017
@szymonkups
Internal: Updated the path to the ClassicEditor class (see https://gi…
ca73838 
…thub.com/ckeditor/ckeditor5-editor-classic/issues/41).
szymonkups referenced this issue in ckeditor/ckeditor5-adapter-ckfinder Jun 19, 2017
@szymonkups
Internal: Updated the path to the ClassicEditor class (see https://gi…
4351d69 
…thub.com/ckeditor/ckeditor5-editor-classic/issues/41).
szymonkups referenced this issue in ckeditor/ckeditor5-autoformat Jun 19, 2017
@szymonkups
Internal: Updated the path to the ClassicEditor class (see https://gi…
a985acd 
…thub.com/ckeditor/ckeditor5-editor-classic/issues/41).
szymonkups referenced this issue in ckeditor/ckeditor5-basic-styles Jun 19, 2017
@szymonkups
Internal: Updated the path to the ClassicEditor class (see https://gi…
30ff783 
…thub.com/ckeditor/ckeditor5-editor-classic/issues/41).
szymonkups referenced this issue in ckeditor/ckeditor5-build-classic Jun 19, 2017
@szymonkups
Internal: Updated the path to the ClassicEditor class (see https://gi…
6d8a2a3 
…thub.com/ckeditor/ckeditor5-editor-classic/issues/41).
szymonkups referenced this issue in ckeditor/ckeditor5-clipboard Jun 19, 2017
@szymonkups
Internal: Updated the path to the ClassicEditor class (see https://gi…
0016cb2 
…thub.com/ckeditor/ckeditor5-editor-classic/issues/41).
szymonkups referenced this issue in ckeditor/ckeditor5-editor-classic Jun 19, 2017
@szymonkups
Other: Renamed the ClassicEditor file to "classiceditor.js" to match …
c5714ba 
…the naming convention. Closes #41.

BREAKING CHANGE: The `classic.js` file containing `ClassicEditor` class has been renamed to `classiceditor.js`.
szymonkups referenced this issue in ckeditor/ckeditor5-enter Jun 19, 2017
@szymonkups
Internal: Updated the path to the ClassicEditor class (see https://gi…
4ee3f03 
…thub.com/ckeditor/ckeditor5-editor-classic/issues/41).
szymonkups referenced this issue in ckeditor/ckeditor5-image Jun 19, 2017
@szymonkups
Internal: Updated the path to the ClassicEditor class (see https://gi…
e6f842a 
…thub.com/ckeditor/ckeditor5-editor-classic/issues/41).
szymonkups referenced this issue in ckeditor/ckeditor5-heading Jun 19, 2017
@szymonkups
Internal: Updated the path to the ClassicEditor class (see https://gi…
9d3c9a5 
…thub.com/ckeditor/ckeditor5-editor-classic/issues/41).
szymonkups referenced this issue in ckeditor/ckeditor5-engine Jun 19, 2017
@szymonkups
Internal: Updated the path to the ClassicEditor class (see https://gi…
a32ec82 
…thub.com/ckeditor/ckeditor5-editor-classic/issues/41).
szymonkups referenced this issue in ckeditor/ckeditor5-link Jun 19, 2017
@szymonkups
Internal: Updated the path to the ClassicEditor class (see https://gi…
41da2e4 
…thub.com/ckeditor/ckeditor5-editor-classic/issues/41).
szymonkups referenced this issue in ckeditor/ckeditor5-list Jun 19, 2017
@szymonkups
Internal: Updated the path to the ClassicEditor class (see https://gi…
ae772ee 
…thub.com/ckeditor/ckeditor5-editor-classic/issues/41).
szymonkups referenced this issue in ckeditor/ckeditor5-paragraph Jun 19, 2017
@szymonkups
Internal: Updated the path to the ClassicEditor class (see https://gi…
5007cdc 
…thub.com/ckeditor/ckeditor5-editor-classic/issues/41).
szymonkups referenced this issue in ckeditor/ckeditor5-essentials Jun 19, 2017
@szymonkups
Internal: Updated the path to the ClassicEditor class (see https://gi…
a9dffdc 
…thub.com/ckeditor/ckeditor5-editor-classic/issues/41).
szymonkups referenced this issue in ckeditor/ckeditor5-typing Jun 19, 2017
@szymonkups
Internal: Updated the path to the ClassicEditor class (see https://gi…
fb51301 
…thub.com/ckeditor/ckeditor5-editor-classic/issues/41).
szymonkups referenced this issue in ckeditor/ckeditor5-undo Jun 19, 2017
@szymonkups
Internal: Updated the path to the ClassicEditor class (see https://gi…
34b4073 
…thub.com/ckeditor/ckeditor5-editor-classic/issues/41).
szymonkups referenced this issue in ckeditor/ckeditor5-ui Jun 19, 2017
@szymonkups
Internal: Updated the path to the ClassicEditor class (see https://gi…
25ba4dc 
…thub.com/ckeditor/ckeditor5-editor-classic/issues/41).
szymonkups referenced this issue in ckeditor/ckeditor5-upload Jun 19, 2017
@szymonkups
Internal: Updated the path to the ClassicEditor class (see https://gi…
7e7258f 
…thub.com/ckeditor/ckeditor5-editor-classic/issues/41).
oleq referenced this issue in ckeditor/ckeditor5-editor-classic Jun 19, 2017
@oleq
Tests: Aligned manual test file names to match the naming convention …
4b079e9 
…introduced in #41.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-editor-classic Oct 8, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:editor-classic labels Oct 8, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 8, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:editor-classic type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 11
3 participants
@Reinmar @oleq @mlewand