Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

T/ckeditor5/479: Enabled the decoupled editor placeholder #25

Merged
merged 22 commits into from Feb 7, 2019

Conversation

oleq
Copy link
Member

@oleq oleq commented Jan 23, 2019

Suggested merge commit message (convention)

Feature: Enabled the decoupled editor placeholder (see ckeditor/ckeditor5#479).

BREAKING CHANGE: The second argument of DecoupledEditorUIView.constructor() is an editing view instance now.


Additional information

Part of the constellation.

@coveralls
Copy link

coveralls commented Jan 25, 2019

Pull Request Test Coverage Report for Build 215

  • 7 of 29 (24.14%) changed or added relevant lines in 3 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-58.3%) to 41.667%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/decouplededitorui.js 4 26 15.38%
Files with Coverage Reduction New Missed Lines %
src/decouplededitorui.js 2 25.64%
src/decouplededitor.js 9 51.85%
Totals Coverage Status
Change from base Build 211: -58.3%
Covered Lines: 28
Relevant Lines: 61

💛 - Coveralls

@pjasiun pjasiun merged commit edd400f into master Feb 7, 2019
@pjasiun pjasiun deleted the t/ckeditor5/479 branch February 7, 2019 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants