Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

T/ckeditor5/479: Enabled the decoupled editor placeholder #25

Merged
merged 22 commits into from Feb 7, 2019
Merged

T/ckeditor5/479: Enabled the decoupled editor placeholder #25

merged 22 commits into from Feb 7, 2019

Commits on Jan 17, 2019

  1. Draft of the placeholder feature.

    @oleq
    oleq committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    23a8f8b View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2019

  1. Merge branch 't/ckeditor5/1449' into t/ckeditor5/479

    @oleq
    oleq committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    cff8655 View commit details
    Browse the repository at this point in the history

  2. Code refactoring and new documentation in the DecoupledEditorUI class.

    @oleq
    oleq committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    2b7135f View commit details
    Browse the repository at this point in the history

  3. Unified the UI destruction process across the editors.

    @oleq
    oleq committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    a2d1220 View commit details
    Browse the repository at this point in the history

  4. Renamed EditableUiView methods related to editing root listeners.

    @oleq
    oleq committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    fec0cb2 View commit details
    Browse the repository at this point in the history

  5. Allowed configurable placeholder text. Added placeholder manual test.

    @oleq
    oleq committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    8a7dc6e View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2019

  1. Refactoring: Renamed getPlaceholderElement to getRootPlaceholderElement.

    @oleq
    oleq committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    3cc6ad7 View commit details
    Browse the repository at this point in the history

  2. Renamed the attachPlaceholder() helper to addPlaceholder().

    @oleq
    oleq committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    761f949 View commit details
    Browse the repository at this point in the history

  3. Renamed detachDomRoots() to detachDomRoot().

    @oleq
    oleq committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    bc69b1b View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2019

  1. Merge branch 'master' into t/ckeditor5/479

    @oleq
    oleq committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    660d48d View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2019

  1. Got rid of *EditableUIView#enableEditingRootListeners(). Moved to ren… 

    …der() because view document root rendering is postponed now.
    @oleq
    oleq committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    432b29b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into t/ckeditor5/479

    @oleq
    oleq committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    e574053 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2019

  1. Aligned to the new EditorUI API.

    @oleq
    oleq committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    1dc9819 View commit details
    Browse the repository at this point in the history

  2. Aligned to the new placeholder helpers API in the engine.

    @oleq
    oleq committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    a9f7c18 View commit details
    Browse the repository at this point in the history

  3. Tests: Added tests to check the placeholder feature of the UI. Code r… 

    …efactoring.
    @oleq
    oleq committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    2624c8e View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2019

  1. Tests: Added placeholder manual test description.

    @oleq
    oleq committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    fdc6688 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into t/ckeditor5/479

    @oleq
    oleq committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    8049700 View commit details
    Browse the repository at this point in the history

  3. Tests: Fixed failng UI tests. [skip ci]

    @oleq
    oleq committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    02493ef View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2019

  1. Tests: Fixed broken tests due to double editor destruction.

    @oleq
    oleq committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    7b1c628 View commit details
    Browse the repository at this point in the history

  2. Tests: Used createRoot helper in the UIView tests.

    @oleq
    oleq committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    086eab1 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2019

  1. Merge branch 'master' into t/ckeditor5/479

    @oleq
    oleq committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    9da1e7c View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2019

  1. Tests: Added UI tests that check the UI destruction order and editor … 

    …element attributes clean–up.
    @oleq
    oleq committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    0728249 View commit details
    Browse the repository at this point in the history