This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Rename editor#dataReady
event as editor.data#ready
#1646
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Introduced
editor.data#ready
event.BREAKING CHANGE: The
editor#dataReady
event was removed. Theeditor.data#ready
event has been introduced and should be used instead.Additional information
See ckeditor/ckeditor5#1477 for more details. This PR mostly covers renaming
dataReady
event (but also necessary adjustments to newplugins#ready
event). The second PR (renamingpluginsReady
event) is ckeditor/ckeditor5-core#157.Created
ckeditor5
branch with all the changes - https://github.com/ckeditor/ckeditor5/tree/t/1477.The list of related PRs in other repos which needed adjustments:
ckeditor5-autosave
- Adjustments to newdata#ready
event ckeditor5-autosave#22ckeditor5-core
- Renameeditor#pluginsReady
event aseditor.plugins#ready
ckeditor5-core#157ckeditor5-editor-balloon
- Adjustments to newdata#ready
event ckeditor5-editor-balloon#27ckeditor5-editor-classic
- Adjustments to newdata#ready
event ckeditor5-editor-classic#80ckeditor5-editor-decoupled
- Adjustments to newdata#ready
event ckeditor5-editor-decoupled#26ckeditor5-editor-inline
- Adjustments to newdata#ready
event ckeditor5-editor-inline#46ckeditor5-ui
- Adjustments to newdata#ready
event ckeditor5-ui#464ckeditor5-paragraph
- Adjustments to newdata#ready
event ckeditor5-paragraph#40