Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Rename editor#dataReady event as editor.data#ready #1646

Merged
merged 4 commits into from
Jan 29, 2019
Merged

Conversation

f1ames
Copy link
Contributor

@f1ames f1ames commented Jan 24, 2019

Suggested merge commit message (convention)

Other: Introduced editor.data#ready event.

BREAKING CHANGE: The editor#dataReady event was removed. The editor.data#ready event has been introduced and should be used instead.


Additional information

See ckeditor/ckeditor5#1477 for more details. This PR mostly covers renaming dataReady event (but also necessary adjustments to new plugins#ready event). The second PR (renaming pluginsReady event) is ckeditor/ckeditor5-core#157.

Created ckeditor5 branch with all the changes - https://github.com/ckeditor/ckeditor5/tree/t/1477.

The list of related PRs in other repos which needed adjustments:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 039af53 on t/ckeditor5/1477 into df8a777 on master.

@pjasiun pjasiun merged commit 46d9243 into master Jan 29, 2019
@pjasiun pjasiun deleted the t/ckeditor5/1477 branch January 29, 2019 09:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants