-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make events consistent by introducing data.ready
and plugins.ready
#1477
Comments
When it comes to This means there will be two events - The second thing, is it possible to have editor creator which does not use |
I think each editor should init engine using |
Other: Remove `editor#pluginsReady` event. Closes ckeditor/ckeditor5#1477. BREAKING CHANGE: The `editor#pluginsReady` event was removed. Use plugin `afterInit()` method instead.
Extracted from #1449.
In #1449 the
editor.uiReady
event was moved fromEditor
toEditorUI
and renamed toready
which meanseditor.uiReady
was replaced witheditor.ui.ready
event.To improve the API and keep it consistent, same could be done with
dataReady
andpluginsReady
events (first is fired by specific editor creators and second by theEditor
instance).The
dataReady
should becomeeditor.data.ready
(fired byDataController
class) andpluginsReady
should becomeeditor.plugins.ready
(fired byPluginCollection
class).The text was updated successfully, but these errors were encountered: