This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Stop invoking view.render() by EditingController when the model document isn't changed
#1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocumentChangedFromTheLastChangeBlock`.
pjasiun
reviewed
Feb 1, 2019
src/model/document.js
Outdated
| * @protected | ||
| * @returns {Boolean} Returns `true` if document has changed from the differ's reset. | ||
| */ | ||
| _hasDocumentChanged() { |
There was a problem hiding this comment.
Suggested change
| _hasDocumentChanged() { | |
| _hasDocumentChangedFromTheLastChangeBlock() { |
pjasiun
reviewed
Feb 1, 2019
src/model/document.js
Outdated
| * @fires change:data | ||
| * @param {module:engine/model/writer~Writer writer} writer The writer on which post-fixers will be called. | ||
| */ | ||
| _runPostFixersAndResetDiffer( writer ) { |
There was a problem hiding this comment.
Suggested change
| _runPostFixersAndResetDiffer( writer ) { | |
| _handleChangeBlock( writer ) { |
There was a problem hiding this comment.
I do not like the current name. The most important thing this method does is firing document#change. However, _runPostFixersAndFireChangeAndResetDiffer sounds ridiculous, so I am for shorter _handleChangeBlock
pjasiun
reviewed
Feb 1, 2019
| // Collect an information whether the model document has changed during from the last pending change. | ||
| hasModelDocumentChanged = hasModelDocumentChanged || this.document._hasDocumentChanged(); | ||
|
|
||
| // Fire '_change' event before resetting differ. | ||
| this.fire( '_change', this._currentWriter ); |
There was a problem hiding this comment.
This event is marked as deprecated on the bottom of that file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Stopped invoking
view.render()byEditingControllerwhen the model document isn't changed. Closes ckeditor/ckeditor5#4473.Additional information
Model#_changeevent marked as deprecated._handleChangeBlock()._hasDocumentChangedFromTheLastChangeBlock().