This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 40
Stop invoking view.render()
by EditingController
when the model document isn't changed
#1657
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
34edf59
Prevented `EditingController` from updating view if there are no chan…
ma2ciek 37510a5
Fixed _runPendingChanges().
ma2ciek bfea595
Introduced `Document#runPostFixersAndResetDiffer` and `Document#_hasD…
ma2ciek 6f1d845
Made runPostFixersAndResetDiffer protected.
ma2ciek 0d19286
Fixed variable names.
ma2ciek 6a990ff
Added missing comment.
ma2ciek d2caf02
Added integration test.
ma2ciek 5af9362
Simplified test.
ma2ciek e362dee
Fixed API docs.
ma2ciek c45f791
Fixed lint issues.
ma2ciek 40b7345
Fixed order of firing _change event and resetting differ.
ma2ciek 5bbeb84
API docs fixes.
ma2ciek 0cb7c9f
Renamed methods. API docs fixes.
ma2ciek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/** | ||
* @license Copyright (c) 2003-2019, CKSource - Frederico Knabben. All rights reserved. | ||
* For licensing, see LICENSE.md. | ||
*/ | ||
|
||
/* globals document */ | ||
|
||
import ClassicTestEditor from '@ckeditor/ckeditor5-core/tests/_utils/classictesteditor'; | ||
import Paragraph from '@ckeditor/ckeditor5-paragraph/src/paragraph'; | ||
|
||
describe( 'Bug ckeditor5-engine#1653', () => { | ||
it( '`DataController.parse()` should not invoke `editing.view.render()`', () => { | ||
let editor; | ||
|
||
const element = document.createElement( 'div' ); | ||
document.body.appendChild( element ); | ||
|
||
return ClassicTestEditor | ||
.create( element, { plugins: [ Paragraph ] } ) | ||
.then( newEditor => { | ||
editor = newEditor; | ||
|
||
const spy = sinon.spy( editor.editing.view, 'render' ); | ||
editor.data.parse( '<p></p>' ); | ||
|
||
sinon.assert.notCalled( spy ); | ||
} ) | ||
.then( () => { | ||
element.remove(); | ||
|
||
return editor.destroy(); | ||
} ); | ||
} ); | ||
} ); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be marked as deprecated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This event is marked as deprecated on the bottom of that file.