This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Improved parseAttributes function performance #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The isPlainObject method is pretty slow, and given that elements are created intensively, reducing cost of this brings notable gains.
Also fixed API docs, as the function is supposed to work with Iterables, see the attrs parameter type in view/Element's constructor (https://ckeditor.com/docs/ckeditor5/15.0.0/api/module_engine_view_element-Element.html#function-constructor).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Improved
parseAttributesfunction performance. This results with improved editor data processing speed. Closes ckeditor/ckeditor5#5854.Additional information
parseAttributesfunction suffered a copy'n'pasta from utils' toMap function. It required same adjustment as in ckeditor/ckeditor5-utils#323. Or even better to reusetoMapfunction, which is what this PR does.A sub-pr of ckeditor/ckeditor5-utils#323.