Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Improved parseAttributes function performance #1822

Merged
merged 3 commits into from
Feb 6, 2020
Merged

Improved parseAttributes function performance #1822

merged 3 commits into from
Feb 6, 2020

Commits on Feb 4, 2020

  1. Internal: Further improved performance by cheaper type checks. 

    The isPlainObject method is pretty slow, and given that elements are created intensively, reducing cost of this brings notable gains.
    @mlewand
    mlewand committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    f62d397 View commit details
    Browse the repository at this point in the history

  2. Internal: Reuse existing function to create a Map. 

    Also fixed API docs, as the function is supposed to work with Iterables, see the attrs parameter type in view/Element's constructor (https://ckeditor.com/docs/ckeditor5/15.0.0/api/module_engine_view_element-Element.html#function-constructor).
    @mlewand
    mlewand committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    e72e216 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2020

  1. Internal: Removed unused reference.

    @mlewand
    mlewand committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    56bd240 View commit details
    Browse the repository at this point in the history