Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Unify widget insertion #232

Merged
merged 1 commit into from
Sep 18, 2018
Merged

Unify widget insertion #232

merged 1 commit into from
Sep 18, 2018

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Sep 13, 2018 •
edited
Loading

Suggested merge commit message (convention)

Other: Image feature should insert image the same way as other widgets.

BREAKING CHANGE: Removed findOptimalInsertionPosition() from utils. The method can be found in Widget feature in widget/utils module.

Additional information

@jodator jodator mentioned this pull request Sep 13, 2018
Merged
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.9%) to 98.062% when pulling 7ec3ce4 on t/ckeditor5/1243 into 9aef1de on master.

@pjasiun pjasiun merged commit 26638f5 into master Sep 18, 2018
@pjasiun pjasiun deleted the t/ckeditor5/1243 branch September 18, 2018 12:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pjasiun pjasiun Awaiting requested review from pjasiun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jodator @coveralls @pjasiun