Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to set editor data (HTML) #138

Closed
oleq opened this issue Dec 23, 2021 · 2 comments · Fixed by #146
Closed

Make it possible to set editor data (HTML) #138

oleq opened this issue Dec 23, 2021 · 2 comments · Fixed by #146
Assignees
Labels
pending:feedback This issue is blocked by necessary feedback. type:feature

Comments

@oleq
Copy link
Member

oleq commented Dec 23, 2021

ATM if you want to set HTML of the editor, you got to do it via browser terminal and editor.setData() (or log editor using the inspector button, store as a global variable, then temp1.setData()). That's a lot of effort for something we do every day over and over again.

I propose we have a dedicated UI for this that will complement the log (copy to clipboard) editor data I implemented recently:

2021-12-23 15 47 16

Highlights:

  • Textarea with data will autofocus to allow typing straight away.
  • I made it possible to use current editor data to make quick adjustments without the need to copy current editor data to the clipboard (a click less).
  • Shift+Enter sets data and closes the modal.
  • The modal closes on Esc.
  • The modal closes on clicking the overlay.

Poc:

@oleq oleq self-assigned this Dec 23, 2021
@oleq oleq added the pending:feedback This issue is blocked by necessary feedback. label Dec 23, 2021
@scofalik
Copy link

Why not use current editor data as the textarea's starting content? (can be select-all'ed after the modal is opened)

@oleq
Copy link
Member Author

oleq commented Feb 1, 2022

Why not use current editor data as the textarea's starting content? (can be select-all'ed after the modal is opened)

That seems like a good idea. I'll try it 👍

psmyrek added a commit that referenced this issue Feb 15, 2022
Feature: Made it possible to set editor data using the UI. Closes #138.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending:feedback This issue is blocked by necessary feedback. type:feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants