The "Log editor data" button should copy to the clipboard if clicked with Alt/Option

[oleq]

Feature: The "Log editor data" button should copy to the clipboard if clicked with Alt/Option. Closes #136.

[przemyslaw-zan]

Perhaps svg names could be clearer?

• clipboard -> copy-to-clipboard
• tick -> checkmark

As far as functionality is concerned, it seems to works as expected. However, if alt is pressed and then released without using the button, Chrome switches focus to options button, and Firefox toggles options bar, both of which is somewhat annoying - this could cause poor user experience IMO. I suppose we don't want to intercept that, since that is default key behavior on these browsers, but perhaps we could consider different key than alt? shift and ctrl do not trigger any additional behavior. Not sure about that one, maybe i'm looking too deep into this.

[oleq]

Thanks for the review @przemyslaw-zan.

As far as functionality is concerned, it seems to works as expected. However, if alt is pressed and then released without using the button, Chrome switches focus to options button, and Firefox toggles options bar, both of which is somewhat annoying - this could cause poor user experience IMO.

What do you mean by "options button" and "options bar"? Is it the UI of the web browser? Because I only tested on Chrome/FF on Mac and there's nothing exceptional happening. Is it an OS thing maybe?

[oleq]

As for the changes in the code, feel free to commit them straight to the PR. They make sense :)

[przemyslaw-zan]

@oleq sorry for not specifying, yes, i meant UI of the browsers, and the behavior happens on Windows

[przemyslaw-zan]

Firefox: (Options bar toggles on and off)

Chrome: (Options button takes focus and prevents further use)

To reiterate, this does not happen when alt + click is used, so it's not exactly a bug. If you think that this is negligible, or not a problem at all. you can merge.

[oleq]

I didn't anticipate that. Nice catch 👍 

I see three options now:

• Stick with Alt (because it's alternate after all) but preventDefault the event
  • 👎 This will break native browser features that you mentioned,
  • 👎 This would also break other features in the editor like typing accents (ąęśćżźćół...),
    • OTOH... I think I already detect when the Alt key is being pressed "solo" only, so maybe this would not happen. Needs to be checked.
• Stick with Alt but preventDefault the event only when the inspector is being hovered
  • 👍 Not breaking native browser features most of the time,
  • 👍 Not breaking accents (most of the time)
    • Or not at all, see my comment in the previous strategy.
  • 👎 Yet breaking both 👆 occasionally (accidentally), which is not a great UX. Quite a surprise when sometimes you can type things and sometimes you cannot.
  • 👎 Annoying if you move the cursor from the top of the page into inspector because the button will change the icon very late.
  • 👎 More complexity in the code.
• Switch to Shift or Ctrl
  • 👍 Not breaking anything this time, I hope.
  • 👍 Low cost of implementation.
  • 👎 Not very intuitive because clearly, the alternate key should... alternate the features. It's a very common pattern, at least on Mac.

Which sounds best to you? I'm lazy so I'd rather go with Shift/Ctrl if confirmed safe.

[przemyslaw-zan]

I agree with you on the last option being the best. Personally, I think that ctrl is the next best choice.

[oleq]

FYI: I used Shift instead of Ctrl. Turns out, Ctrl+Click is already intercepted and opens the native "right click" context menu. If I went with Ctrl, I'd have to preventDefault the 'contextmenu' event which sounds like unnecessary trouble.

[przemyslaw-zan]

LGTM