This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Removed the confirmation of mention selection by using space #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Travis checks seem to have failed because of issues not related to this PR. Got all tests green on my side. |
fredck
force-pushed
the
t/ckeditor5/6394
branch
from
9d4b261
to
e71b42c
Compare
|
Force-pushed a rebase over v18.0.0. |
fredck
changed the title
|
The Because of the above I've reverted the changes related to the |
|
Force-pushed a rebase over v19.0.0. |
|
It would be great to see this fix in the next release! |
|
The PR has been moved to ckeditor/ckeditor5#7306. For those interested, be sure to add 👍 and further feedback there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: The
spaceandtabkeys are not anymore used to confirm a mention selection from the list. Closes ckeditor/ckeditor5#6394.