This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Page break label element should have a fixed font #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleq
reviewed
Oct 1, 2019
There was a problem hiding this comment.
I'm not so sure about it. I managed to mangle the label by using font-style and letter-spacing.
- It could be the right case for
.ck.ck-reset(_all) - (general question about
pagebreak.css) Are those styles content or editing styles?- If content, why there's no
.ck-contentselector before them? - If editing, why things like
border-radiusorcolorare inckeditor5-page-breakand not intheme-lark?
- If content, why there's no
|
It will be fixed here: #10 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal: Page break label element should have a fixed font. Closes ckeditor/ckeditor5#4687 .
Additional information