Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagebreak.css needs some refactoring #4690

Closed
oleq opened this issue Oct 1, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-page-break#10
Closed

Pagebreak.css needs some refactoring #4690

oleq opened this issue Oct 1, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-page-break#10
Assignees
@dkonopka
Labels
package:page-break type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 27 (v15...

Comments

@oleq
Copy link
Member

oleq commented Oct 1, 2019

As per ckeditor/ckeditor5-page-break#7 (review), we should figure out which are

  • the content styles (if there are any at all; if some are, they should be prefixed by .ck-content),
  • editing styles
    • and why they are here and not in theme-lark (only things like display, position, etc. should remain in ckeditor5-page-break)
oleq referenced this issue in ckeditor/ckeditor5-page-break Oct 7, 2019
@oleq
Merge pull request #10 from ckeditor/t/9
b561e9f 
Internal: Introduced content styles for the page break feature. Code refactoring. Closes #9. Closes #8. Closes #6.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-page-break Oct 9, 2019
@mlewand mlewand added this to the iteration 27 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:page-break labels Oct 9, 2019
@dkonopka dkonopka mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkonopka dkonopka

Labels
package:page-break type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 27 (v15.0.0)
Development

Successfully merging a pull request may close this issue.

Introduced content styles for a page break. ckeditor/ckeditor5-page-break
3 participants
@oleq @mlewand @dkonopka