This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
t/ckeditor5/810: Made the link form buttons thicker with a fill color and no background. #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oleq what do you think about increasing lightness of green color? Change is really noticeable in the dark-theme and still, it looks good in cooperation with the lighter hue. Proposal: Current color vs proposal in the dark theme
Current color vs proposal in the light theme
|
|
This is the brightest I could get staying in AA boundaries. Check out the a11y tools in Google Chrome. Besides, the inverted theme can customize the colors. |
|
Ok, so if someone will decide to use dark theme customization will be necessary. I'm ok with that. |
dkonopka
approved these changes
Mar 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Made the link form buttons thicker with a fill color and no background (see ckeditor/ckeditor5#810).