Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research different looks of balloon navigation buttons #810

Closed
oleq opened this issue Feb 2, 2018 · 4 comments
Closed

Research different looks of balloon navigation buttons #810

oleq opened this issue Feb 2, 2018 · 4 comments

Comments

@oleq
Copy link
Member

oleq commented Feb 2, 2018

ATM we use a green background for "save" and no background for cancel:

image

but we could use a different approach to make it even more lightweight (possibly making the icons thicker):

image

image

A follow-up of #645.

@oleq
Copy link
Member Author

oleq commented Feb 15, 2018

Slightly thicker icons
image

@dkonopka
Copy link
Contributor

Like we were talking, the current green button with save icon looks like focused state and some users can be confused. So I'm for removing the background of it.

Coloured thicker icons look really well also in inverted theme (but we need to change a bit hue of green) and this is my favorite version.

screen shot 2018-02-19 at 15 24 34

@jodator
Copy link
Contributor

jodator commented Mar 12, 2018

I like the fat version of two color variant.

@scofalik
Copy link
Contributor

+1 two colors, thick.

@oleq oleq added this to the iteration 15 milestone Mar 13, 2018
@oleq oleq self-assigned this Mar 13, 2018
dkonopka added a commit to ckeditor/ckeditor5-theme-lark that referenced this issue Mar 15, 2018
Feature: Made the link form buttons thicker with a fill color and no background (see ckeditor/ckeditor5#810).
dkonopka added a commit to ckeditor/ckeditor5-core that referenced this issue Mar 15, 2018
Other: Made the check and cancel icons thicker and fill-friendly (see ckeditor/ckeditor5#810).
dkonopka added a commit to ckeditor/ckeditor5-link that referenced this issue Mar 15, 2018
Feature: Made the link form buttons thicker with a fill color and no background (see ckeditor/ckeditor5#810).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants