Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Feature: Added BlockToolbar styles. #175

Merged
merged 3 commits into from
May 30, 2018
Merged

Feature: Added BlockToolbar styles. #175

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a52ae3
Changed naming of block toolbar.
May 18, 2018
1d42f2f
Changed naming of block toolbar.
May 18, 2018
bad1ebc
Removed unused styles.
oskarwrobel May 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 14 additions & 0 deletions theme/ckeditor5-ui/components/toolbar/blocktoolbar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
/*
* Copyright (c) 2003-2018, CKSource - Frederico Knabben. All rights reserved.
* For licensing, see LICENSE.md.
*/

:root {
--ck-color-block-toolbar-button: var(--ck-color-text);
--ck-block-toolbar-button-size: var(--ck-font-size-normal);
}

.ck.ck-block-toolbar-button {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not .ck-block-button? IIRC it's BlockButtonView https://github.com/ckeditor/ckeditor5-ui/pull/392/files#diff-25f0cf1953c3fa884ca284a6c91b1f22R24.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, where does the BlockButtonView live in DOM? Which element is its parent? (it could have an impact on the class name)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Button is directly in a body collection. cc @dkonopka.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it makes sense, I think.

color: var(--ck-color-block-toolbar-button);
font-size: var(--ck-block-toolbar-size);
}