Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Commit

Permalink
Merge pull request #107 from ckeditor/t/106
Browse files Browse the repository at this point in the history
Moved DomEmitterMixin to utils.
  • Loading branch information
szymonkups committed Nov 10, 2016
2 parents 9e86c00 + 07af815 commit 7d4c0fc
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 773 deletions.
294 changes: 0 additions & 294 deletions src/domemittermixin.js

This file was deleted.

4 changes: 2 additions & 2 deletions src/template.js
Original file line number Diff line number Diff line change
Expand Up @@ -852,8 +852,8 @@ function getStyleUpdater( el, styleName ) {
function clone( def ) {
const clone = cloneDeepWith( def, value => {
// Don't clone the `Template.bind`* bindings because of the references to Observable
// and DOMEmitterMixin instances inside, which would also be traversed and cloned by greedy
// cloneDeepWith algorithm. There's no point in cloning Observable/DOMEmitterMixins
// and DomEmitterMixin instances inside, which would also be traversed and cloned by greedy
// cloneDeepWith algorithm. There's no point in cloning Observable/DomEmitterMixins
// along with the definition.
//
// Also don't clone View instances if provided as a child of the Template. The template
Expand Down
8 changes: 4 additions & 4 deletions src/view.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import CKEditorError from '../utils/ckeditorerror.js';
import ViewCollection from './viewcollection.js';
import Template from './template.js';
import DOMEmitterMixin from './domemittermixin.js';
import DomEmmiterMixin from '../utils/dom/emittermixin.js';
import ObservableMixin from '../utils/observablemixin.js';
import Collection from '../utils/collection.js';
import mix from '../utils/mix.js';
Expand Down Expand Up @@ -44,8 +44,8 @@ import mix from '../utils/mix.js';
* } );
*
* @memberOf ui
* @mixes DOMEmitterMixin
* @mixes ObservableMixin
* @mixes utils.dom.EmmiterMixin
* @mixes utils.ObservableMixin
*/
export default class View {
/**
Expand Down Expand Up @@ -298,5 +298,5 @@ export default class View {
}
}

mix( View, DOMEmitterMixin );
mix( View, DomEmmiterMixin );
mix( View, ObservableMixin );
Loading

0 comments on commit 7d4c0fc

Please sign in to comment.