This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
t/6: Added Controller.addCollection() method #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * See {@link ui.ControllerCollection#locale}. | ||
| */ | ||
| addCollection( collectionName, locale ) { | ||
| const collection = new ControllerCollection( collectionName, locale ); |
There was a problem hiding this comment.
Do we have to pass the locale? Can't it be taken here from this.view.locale?
| * See {@link ui.ControllerCollection#locale}. | ||
| * @returns {ui.ControllerCollection} The new collection instance. | ||
| */ | ||
| addCollection( collectionName, locale ) { |
There was a problem hiding this comment.
My previous comment disappeared – can't we take locale from this.view.locale?
There was a problem hiding this comment.
That's a good idea. I'll fix it post–review.
|
If https://github.com/ckeditor/ckeditor5-ui/pull/50/files#r72650075 can be simplified, feel free to create an issue for it. I'm merging the rest of the code. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ckeditor/ckeditor5#5211. Requires ckeditor/ckeditor5#5231.