Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize data via setData() doesn't work properly #47

Closed
elszczepano opened this issue Apr 18, 2019 · 1 comment · Fixed by #48
Closed

Initialize data via setData() doesn't work properly #47

elszczepano opened this issue Apr 18, 2019 · 1 comment · Fixed by #48
Assignees
@elszczepano
Labels
type:bug
Milestone
iteration 24

Comments

@elszczepano
Copy link
Member

editor.setData() or editor.data.set() in real-time collaboration works incorrect. Using it may overwrite local changes on remote clients.
@pomek
Copy link
Member

pomek commented Apr 18, 2019

A related issue in React integration – ckeditor/ckeditor5-react#68.

@elszczepano elszczepano mentioned this issue Apr 18, 2019
Merged
@oleq oleq added this to the iteration 24 milestone Apr 18, 2019
@oleq oleq closed this as completed in #48 Apr 19, 2019
oleq added a commit that referenced this issue Apr 19, 2019
@oleq
Merge pull request #48 from ckeditor/t/47
6f821fa 
Fix: The data initialization should not break collaboration. Instead of using `editor.setData()`, the initial content is now set via `innerHTML` of the source element. Closes #47.
@ma2ciek ma2ciek mentioned this issue Apr 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elszczepano elszczepano

Labels
type:bug
Projects
None yet
Milestone
iteration 24
Development

Successfully merging a pull request may close this issue.

T/47 ckeditor/ckeditor5-vue
3 participants
@oleq @pomek @elszczepano