T/47 #48
T/47 #48
Conversation
tests/ckeditor.js
Outdated
| @@ -104,19 +104,6 @@ describe( 'CKEditor Component', () => { | |||
| expect( vm.value ).to.equal( '' ); | |||
| } ); | |||
|
|
|||
| it( 'should set the initial data', done => { | |||
There was a problem hiding this comment.
This test should not be removed. We need to be sure that the specified data has been passed to the editor.
tests/ckeditor.js
Outdated
| it( 'should set the initial data', done => { | ||
| const setDataStub = sandbox.stub( MockEditor.prototype, 'setData' ); | ||
| const { wrapper } = createComponent( { | ||
| it( 'should set the initial data by using innerHTML, not by "setData()"', done => { |
| return createElement( this.tagName ); | ||
| return createElement(this.tagName, { | ||
| domProps: { | ||
| innerHTML: this.value || '' |
There was a problem hiding this comment.
Does this work when tagName is textarea?
There was a problem hiding this comment.
I'm worried because setting the value of an input like this works only once (the second one will be ignored). In theory, we do it only once but still, this is not the right way IMO.
There was a problem hiding this comment.
Also... does this whole innerHTML thing work when a content with/without entities is passed as a value?
There was a problem hiding this comment.
I've built a sample with tagName set to textarea. The editor seems to work properly, no error occurs on init and on destroy.
Suggested merge commit message (convention)
Fix: Changed the way of data initialization. Instead of using
setData(), the content is set viainnerHTML. Closes #47.