Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i/101: Editor config defined in the component should not be mutable #103

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

oleq
Copy link
Member

@oleq oleq commented Oct 22, 2019

Suggested merge commit message (convention)

Fix: Editor config defined in the component should not be mutable. Closes #101.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 96

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 94: 0.0%
Covered Lines: 31
Relevant Lines: 31

💛 - Coveralls

@pomek
Copy link
Member

pomek commented Nov 4, 2019

This PR is good. However, shouldn't we consider adding this feature to Editor class? The same problem can occur in other integrations.

@pomek
Copy link
Member

pomek commented Nov 4, 2019

☝️ Even if we add the fix in Editor class, the original issue will still stay because the problem occurs when a user creates the Vue component. Before the component calls Editor.create(), the config is being modified. Adding a fix to Editor.create() is a little too late and we will still need the fix here.

@pomek pomek merged commit 42651e3 into master Nov 4, 2019
@pomek pomek deleted the i/101 branch November 4, 2019 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shared ckconfig cause shared init value
3 participants