Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marked the editor instance as a raw object #209

Merged
merged 3 commits into from
Mar 17, 2022
Merged

Marked the editor instance as a raw object #209

merged 3 commits into from
Mar 17, 2022

Conversation

psmyrek
Copy link
Contributor

@psmyrek psmyrek commented Mar 16, 2022

Suggested merge commit message (convention)

Fix: Marked the editor instance this.instance as a raw object so that it will never be converted to a proxy. Closes #203.

Internal: Renamed the internal properties and methods: $_instance -> instance, $_lastEditorData -> lastEditorData and $_setUpEditorEvents() -> setUpEditorEvents().

Internal: Bumped dev dependencies.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@coveralls
Copy link

coveralls commented Mar 16, 2022

Pull Request Test Coverage Report for Build 236

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 230: 0.0%
Covered Lines: 34
Relevant Lines: 34

💛 - Coveralls

Copy link
Member

@przemyslaw-zan przemyslaw-zan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & WFM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'model')
4 participants