Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

this.$_instance is undefined error #21

Closed
andy3471 opened this issue May 3, 2022 · 3 comments · Fixed by #22
Closed

this.$_instance is undefined error #21

andy3471 opened this issue May 3, 2022 · 3 comments · Fixed by #22
Assignees
@psmyrek
Labels
squad:devops Issue to be handled by the Devops team. type:bug
Milestone
iteration 53

Comments

@andy3471
Copy link

andy3471 commented May 3, 2022

I'm getting the error this.$_instance is undefined when using ckeditor5-vue2 3.0.0 with Vue 2.6.12.

Screenshot from 2022-05-03 16-28-06

This was fixed in the ckeditor-vue3 in PR209, however the changes do not seem to be in ckeditor5-vue2, and the error still persists.
@FilipTokarski
Copy link
Member

@psmyrek Could you take a look at this? 🙏

@psmyrek psmyrek self-assigned this May 16, 2022
@psmyrek psmyrek added type:bug squad:devops Issue to be handled by the Devops team. labels May 16, 2022
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label May 16, 2022
@psmyrek
Copy link
Contributor

psmyrek commented May 16, 2022

Thank you for reporting this issue. The mentioned PR ckeditor/ckeditor5-vue#209 from the ckeditor5-vue concerned another issue, strictly related to the Vue 3, which tries to convert the editor instance to a proxy.

This issue concerns the case, when the model value is changed, but the editor is not ready yet, so the watcher is not able to set the data on the editor instance. I will fix this issue soon.

This was referenced May 16, 2022
Merged
Merged
Closed
@pomek pomek closed this as completed in #22 May 18, 2022
pomek added a commit that referenced this issue May 18, 2022
@pomek
Merge pull request #22 from ckeditor/i/21
9c56952 
Fix: Synchronize the editor content after the editor is ready. Closes #21.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label May 18, 2022
@pomek
Copy link
Member

pomek commented May 18, 2022

Released as https://github.com/ckeditor/ckeditor5-vue2/releases/tag/v3.0.1.

@CKEditorBot CKEditorBot added this to the iteration 53 milestone May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psmyrek psmyrek

Labels
squad:devops Issue to be handled by the Devops team. type:bug
Projects
None yet
Milestone
iteration 53
Development

Successfully merging a pull request may close this issue.

Synchronize the editor content after the editor is ready ckeditor/ckeditor5-vue2
5 participants
@pomek @andy3471 @CKEditorBot @FilipTokarski @psmyrek