Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core+autosave tests fail to execute together #1158

Closed
Reinmar opened this issue Jul 17, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-autosave#16
Closed

core+autosave tests fail to execute together #1158

Reinmar opened this issue Jul 17, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-autosave#16
Assignees
@ma2ciek
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 20

Comments

@Reinmar
Copy link
Member

Reinmar commented Jul 17, 2018 

npm t -- --files=core,autosave

Fails on a couple of plugin tests. The opposite order autosave,core works fine. I think that it may be due to the use of fake timers.
@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. status:confirmed labels Jul 17, 2018
@Reinmar Reinmar added this to the iteration 20 milestone Jul 17, 2018
@ma2ciek ma2ciek mentioned this issue Jul 17, 2018
Closed
@ma2ciek ma2ciek mentioned this issue Aug 13, 2018
Merged
pjasiun pushed a commit to ckeditor/ckeditor5-autosave that referenced this issue Aug 16, 2018
Merge pull request #16 from ckeditor/t/12
820e060 
Other: Improved call frequency. Closes #9. Closes #10. Closes #12. Closes ckeditor/ckeditor5#1158.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ma2ciek ma2ciek

Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 20
Development

Successfully merging a pull request may close this issue.

Improve call frequency ckeditor/ckeditor5-autosave
2 participants
@Reinmar @ma2ciek