This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Improve call frequency #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjasiun
reviewed
Aug 13, 2018
src/autosave.js
Outdated
|
|
||
| // A minimum amount of time that needs to pass after the last action. | ||
| // After that time the provided save callbacks are being called. | ||
| const waitingTime = config.waitingTime || 2000; |
There was a problem hiding this comment.
There was a problem hiding this comment.
After #12 (comment) default timeout should work in most cases and is should not need to be configurable.
There was a problem hiding this comment.
Also, I am not sure if 2000 is not too much. Maybe 1000?
There was a problem hiding this comment.
After #12 (comment) default timeout should work in most cases and it should not need to be configurable.
Right, I overlooked it.
Also, I am not sure if 2000 is not too much. Maybe 1000?
The last call will be on the Editor#destroy or Window#beforeunload, so IMO we can use a higher value here.
pjasiun
reviewed
Aug 13, 2018
src/autosave.js
Outdated
| } | ||
|
|
||
| // Do nothing if the plugin is in `external-saving` state. |
There was a problem hiding this comment.
A comment is needed that is will be handled based on the document version.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Improved call frequency. Closes ckeditor/ckeditor5#2539. Closes ckeditor/ckeditor5#2541. Closes ckeditor/ckeditor5#2547. Closes ckeditor/ckeditor5#1158.
Additional information
This PR Introduces
Autosave#state, which can have the following values:adapter#save()andconfig.autosave.save()It switches from
throttleto lodash'sdebounceIt makes the timeout configurable