Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Column resize should provide conversion for width style on individual cell #12426

Closed
mlewand opened this issue Sep 7, 2022 · 0 comments · Fixed by #12472
Closed

Column resize should provide conversion for width style on individual cell #12426

mlewand opened this issue Sep 7, 2022 · 0 comments · Fixed by #12472
Assignees
@pszczesniak
Labels
intro Good first ticket. package:table squad:features Issue to be handled by the Features team. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 57 (v35...

Comments

@mlewand
Copy link
Contributor

mlewand commented Sep 7, 2022

📝 Provide a description of the improvement

Currently if you copy (to your clipboard) a table like:

<table style="width:399px">
	<tbody>
		<tr>
			<td style="width:94px">&nbsp;</td>
			<td style="width:291px">&nbsp;</td>
		</tr>
		<tr>
			<td style="width:94px">&nbsp;</td>
			<td style="width:291px">&nbsp;</td>
		</tr>
	</tbody>
</table>

Table in CKEditor 4

And paste it into the CKEditor 5 column resize sample it will ignore the cell widths and look in a following way:

The reason for this is that we didn't include cell properties plugin in this sample. This plugin brings conversion and command for cell width.

The problem is that it includes also plenty of other features (like cell background, border) that are not desired in case someone enables the column resize plugin. So we need to extract cell width to an atomic plugin that will be required by both CellPropertiesEditing and TableColumnResizeEditing.

To sum up:

  1. Let's extract cell width to CellWidthEditing plugin.
  2. This plugin needs to go to requires list of cell properties editing and column resize editing plugin.

📃 Other details

  • Browser: Any
  • OS: Any
  • CKEditor version: …
  • Installed CKEditor plugins: …
@mlewand mlewand added type:improvement This issue reports a possible enhancement of an existing feature. intro Good first ticket. package:table squad:features Issue to be handled by the Features team. labels Sep 7, 2022
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Sep 7, 2022
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Sep 9, 2022
@pszczesniak pszczesniak mentioned this issue Sep 14, 2022
Merged
@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Sep 21, 2022
Dumluregn added a commit that referenced this issue Sep 23, 2022
@Dumluregn
Merge pull request #12472 from ckeditor/ck/12426-column-resize-conver…
21a7ed2 
…sion-for-width-style-on-cell

Fix (table): Table cell widths will be preserved after pasting into the editor with table column resize feature and without table cell properties one. Closes #12426.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 23, 2022
@CKEditorBot CKEditorBot added this to the iteration 57 milestone Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pszczesniak pszczesniak

Labels
intro Good first ticket. package:table squad:features Issue to be handled by the Features team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 57 (v35.2.0)
Development

Successfully merging a pull request may close this issue.

Ck/12426 column resize conversion for width style on cell ckeditor/ckeditor5
3 participants
@mlewand @pszczesniak @CKEditorBot