Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlainTableOutput does not work with TableColumnResize (not possible to get data from the editor) #13164

Closed
dufipl opened this issue Dec 28, 2022 · 0 comments · Fixed by #13265
Assignees
Labels
package:table squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@dufipl
Copy link
Contributor

dufipl commented Dec 28, 2022

📝 Provide detailed reproduction steps (if any)

  1. Enable PlainTableOutput and TableColumnResize (e.g. using GHS-all-features manual test)
  2. Add a table and change the width of any column.
  3. Try to get the editor's data by editor.getData() or open SourceEditing

✔️ Expected result

Data obtained/source shown

❌ Actual result

Error in the console, not possible to obtain data/show editor's source:

converters.js:98 Uncaught TypeError: Cannot read properties of undefined (reading 'getChildren')
    at insertColgroupElement (converters.js:98:1)
    at DowncastDispatcher.<anonymous> (converters.js:79:1)
    at DowncastDispatcher.fire (emittermixin.ts:241:1)
    at DowncastDispatcher._testAndFire (downcastdispatcher.ts:615:1)
    at DowncastDispatcher._testAndFireAddAttributes (downcastdispatcher.ts:639:1)
    at Object.convertAttributes (downcastdispatcher.ts:666:1)
    at DowncastDispatcher.<anonymous> (downcasthelpers.ts:1248:1)
    at DowncastDispatcher.fire (emittermixin.ts:241:1)
    at DowncastDispatcher._testAndFire (downcastdispatcher.ts:615:1)
    at DowncastDispatcher._convertInsert (downcastdispatcher.ts:331:1)

📃 Other details

  • Browser: Any
  • OS: Mac OS Monterey

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@dufipl dufipl added type:bug This issue reports a buggy (incorrect) behavior. package:table squad:core Issue to be handled by the Core team. labels Dec 28, 2022
@martynawierzbicka martynawierzbicka added the support:2 An issue reported by a commercially licensed client. label Dec 28, 2022
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 12, 2023
niegowski added a commit that referenced this issue Jan 13, 2023
…-and-tablecolumn-resize-compatibility

Fix (table): The editor should not crash on `getData()` call if the `PlainTableOutput` is used with the `TableColumnResize` feature. Closes #13164.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 13, 2023
@CKEditorBot CKEditorBot added this to the iteration 60 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:table squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants