-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deleting and entering newlines (soft enter) at the end of long document causes auto-scroll to top #14028
Comments
This issue could have the same underlying issue as #14605 |
@mlewand AFAICS it happens when the selection lands after delete at the end of a soft brake. The same case as in a code block, right? |
This is happening because this code can't resolve proper client rect and falls back to parent container bounding rect: ckeditor5/packages/ckeditor5-utils/src/dom/rect.ts Lines 386 to 407 in cfab99d
|
After a deeper checking, I noticed that the The line responsible for not adding an inline filler is: ckeditor5/packages/ckeditor5-engine/src/view/renderer.ts Lines 525 to 528 in 5028271
And while checking the ckeditor5/packages/ckeditor5-engine/src/view/containerelement.ts Lines 83 to 86 in 5028271
but this was not applied to the inline filler logic that should allow for inline filler next to a block filler if this is after another |
Where and what is the solution @Witoso ?? |
@Rashid101 there's none, this is an open bug on our side. Please +1 (:+1: ), the top comment. |
Fix (engine): An inline filler should be rendered after a BR just before a block filler so that scrolling to selection could properly find the client rect. Closes #14028.
📝 Provide detailed reproduction steps (if any)
✔️ Expected result
No auto-scrolling occurs
❌ Actual result
The page auto-scrolls to the top of the CKEditor field.
(See attached video file for video demonstration)
📃 Other details
If you'd like to see this fixed sooner, add a 👍 reaction to this post.
ckeditor_autoscroll_bug_on_demo_page.webm
long_text_file_no_html_tags.txt
The text was updated successfully, but these errors were encountered: