Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On image upload set the width and height attributes #14202

Closed
Witoso opened this issue May 22, 2023 · 0 comments · Fixed by #14305
Closed

On image upload set the width and height attributes #14202

Witoso opened this issue May 22, 2023 · 0 comments · Fixed by #14305
Assignees
@mmotyczynska
Labels
package:image squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 67 (v40...

Comments

@Witoso
Copy link
Member

Witoso commented May 22, 2023

As described in the umbrella issue #14146 the width and height attributes are crucial to prevent the layout shift. We should set them on the image upload.

Scope

  • When an image is uploaded, set width and height on the img.
  • It should work with our current adapters (CKBox, EasyImage, Base64, SimpleUpload) as well as custom ones.
  • Update the image docs to mention, we set those attributes. As it's a complex matter, let's consult CCX on how to surface this info.

TBD (we need to experiment)

  • When to set it? When loading a placeholder to the editor from the blob? What API options do we have? Maybe after the upload?
  • Should we set it by default or some configuration option should be turned on?
@Witoso Witoso added type:task This issue reports a chore (non-production change) and other types of "todos". package:image squad:core Issue to be handled by the Core team. labels May 22, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label May 22, 2023
@Witoso Witoso mentioned this issue May 22, 2023
Closed
10 tasks
@mmotyczynska mmotyczynska self-assigned this May 25, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels May 25, 2023
@mmotyczynska mmotyczynska mentioned this issue May 31, 2023
Merged
@Witoso Witoso mentioned this issue Jun 1, 2023
Closed
mmotyczynska added a commit that referenced this issue Jun 26, 2023
@mmotyczynska
Merge pull request #14305 from ckeditor/ck/14202-set-image-width-and-…
1f602a7 
…height-on-upload

Feature (image): After inserting an image, the width and height attributes should be set automatically. Closes #14202.
@arkflpc arkflpc closed this as completed Jul 3, 2023
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jul 3, 2023
@CKEditorBot CKEditorBot added this to the upcoming milestone Jul 3, 2023
@CKEditorBot CKEditorBot modified the milestones: upcoming, iteration 67 Sep 14, 2023
@mmotyczynska mmotyczynska mentioned this issue Sep 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmotyczynska mmotyczynska

Labels
package:image squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 67 (v40.0.0)
Development

Successfully merging a pull request may close this issue.

Set image width and height on upload ckeditor/ckeditor5
4 participants
@arkflpc @Witoso @CKEditorBot @mmotyczynska