Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image width and height on image paste #15088

Closed
mmotyczynska opened this issue Sep 28, 2023 · 1 comment
Closed

Add image width and height on image paste #15088

mmotyczynska opened this issue Sep 28, 2023 · 1 comment
Assignees
@niegowski @mmotyczynska
Labels
package:image release:blocker This issue blocks the upcoming release (is critical). squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 67 (v40...

Comments

@mmotyczynska
Copy link
Contributor

mmotyczynska commented Sep 28, 2023 •
edited
Loading

Provide a description of the task

Image width and height should be added when the copied image is pasted into the editor.

Some background:
An image should get width and height attributes when it is added to the editor or when the user modifies an image.
We've already introduced these changes e.g.:
Setting image width and height on image upload
Setting image width and height on image change (resize, style, type...)

However, these changes did not cover pasting the image into the editor. So, for consistency, we should cover this case as well.

📃 Other details

  • Browser: …
  • OS: …
  • CKEditor version: …
  • Installed CKEditor plugins: …
@mmotyczynska mmotyczynska added type:task This issue reports a chore (non-production change) and other types of "todos". package:image squad:core Issue to be handled by the Core team. release:potential-blocker This issue potentially blocks the upcoming release (should be checked). labels Sep 28, 2023
@mmotyczynska mmotyczynska self-assigned this Sep 28, 2023
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 28, 2023
@mmotyczynska mmotyczynska mentioned this issue Sep 28, 2023
Merged
@Reinmar Reinmar added release:blocker This issue blocks the upcoming release (is critical). and removed release:potential-blocker This issue potentially blocks the upcoming release (should be checked). labels Sep 29, 2023
arkflpc added a commit that referenced this issue Oct 2, 2023
@arkflpc
Merge pull request #15092 from ckeditor/ck/15088-add-image-sizes-on-i…
47accf1 
…mage-paste

Internal (image): Image `width` and `height` attributes should be added when pasting a copied image. Closes #15088.
@niegowski
Copy link
Contributor

Closed by #15092.

@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Oct 2, 2023
@Witoso Witoso added this to the iteration 67 milestone Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

@mmotyczynska mmotyczynska

Labels
package:image release:blocker This issue blocks the upcoming release (is critical). squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 67 (v40.0.0)
Development

No branches or pull requests
5 participants
@Reinmar @niegowski @Witoso @CKEditorBot @mmotyczynska